-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README for greater consistency with styled API #70
base: master
Are you sure you want to change the base?
Conversation
for greater consistency with styled API
Also it is a little shorter |
wait this works? @jquense why don't we use this then |
I think it's less good of a syntax personally, with Happy to show it in the readme but I think we should prefer the function generally |
@jquense yeap, we can do it in a different way. We just need to explain for styled components users that they do not need to change the syntax. Do you have an idea how to do it? |
@jquense |
for sure we should show it and illustrate a migration path, I just don't think we should do so at the expense of now using the other syntax at all. Can we add a section that shows both? and/or some copy for folks coming from SC or emotion? |
Maybe it is a good time to write a special section for Migration from SC. We can cover there:
|
I think it would be more convenient for users who switch from styled-components
Reference #33